Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab sync fails if project doesn't have CI/CD enabled #277

Closed
thomas-gerber opened this issue Feb 2, 2023 · 2 comments
Closed

GitLab sync fails if project doesn't have CI/CD enabled #277

thomas-gerber opened this issue Feb 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@thomas-gerber
Copy link
Contributor

Describe the bug
When a project does not have CI/CD activated, the sync will fail because of 403 API errors during the pipeline stream.

Screenshots and logs
If applicable, add screenshots and logs to help explain your problem.

Screenshot 2023-02-01 at 6 56 26 PM

403 Client Error: Forbidden for url: https://gitlab.com/api/v4/projects/[redacted]/pipelines?per_page=50&updated_after=2023-01-03T02%3A49%3A24Z
@thomas-gerber thomas-gerber added the bug Something isn't working label Feb 2, 2023
@thomas-gerber
Copy link
Contributor Author

@cjwooo would it be a good idea to silently ignore streams that produce 403s?

@cjwooo
Copy link
Contributor

cjwooo commented Feb 2, 2023

I think we should still error in cases like this, so that the connector will still signal to the user that there could be an authn/z issue. If the user determines afterwards that the cause was a feature not being enabled, e.g. CI/CD for a GitLab project, they should explicitly disable the stream.

@thomas-gerber thomas-gerber closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants