Add pull request option support #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalenge
requested review from
willmarks and
tovbinm
and removed request for
willmarks
tovbinm
reviewed
Apr 12, 2022
tovbinm
reviewed
Apr 12, 2022
tovbinm
reviewed
Apr 12, 2022
Signed-off-by: Chalenge Masekera <chalenge@faros.ai>
willmarks
reviewed
Apr 12, 2022
faros_event.sh
Outdated
| @@ -107,20 +108,22 @@ function help() { | |||
| echo "--deploy_status | Yes | $deploy_statuses" | |||
| echo "--artifact | *2 | $artifact_uri_form" | |||
| echo "--commit | *2 | $commit_uri_form" | |||
| echo "--pull_request_number | | *3 | e.g. 123 (should be a number)" | |||
There was a problem hiding this comment.
I think we want *3 to be in Req column
There was a problem hiding this comment.
It is never required, so maybe --pull_request_number | | *3 e.g. 123 (should be a number)"
There was a problem hiding this comment.
+1 @willmarks it's conditionally required, that's whye there is the *
tovbinm
reviewed
Apr 12, 2022
README.md
Outdated
| @@ -101,6 +101,7 @@ A `CI` event communicates the outcome of a code build pipeline execution, and it | |||
| | Argument | Description | Required | Allowed Value | | |||
| | ---------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------- | ----------------------------------------------------------- | | |||
| | ‑‑commit | The URI of the commit. (`<source>://<organization>/<repository>/<commit_sha>` e.g. `GitHub://faros-ai/my-repo/da500aa4f54cbf8f3eb47a1dc2c136715c9197b9`) | Yes | | | |||
| | ‑‑pull_request_number | The pull request number of the commit. (`e.g. 1`) | | | | |||
tovbinm
reviewed
Apr 12, 2022
README.md
Outdated
| @@ -123,6 +124,7 @@ A `CD` event communicates the outcome of an application deployment pipeline exec | |||
| | ‑‑deploy_status | The status of the deployment. | Yes | Success, Failed, Canceled, Queued, Running, RolledBack, Custom | | |||
| | ‑‑artifact | The URI of the artifact. (`<source>://<organization>/<repository>/<artifact_id>` e.g. `DockerHub://farosai/my-repo/da500aa4f54cbf8f3eb47a1dc2c136715c9197b9`) | Either ‑‑commit or ‑‑artifact | | | |||
| | ‑‑commit | The URI of the commit. (`<source>://<organization>/<repository>/<commit_sha>` e.g. `GitHub://faros-ai/my-repo/da500aa4f54cbf8f3eb47a1dc2c136715c9197b9`) | Either ‑‑commit or ‑‑artifact | | | |||
| | ‑‑pull_request_number | The pull request number of the commit. (`e.g. 1`). Used only if --commit is included | | | | |||
tovbinm
reviewed
Apr 12, 2022
| ../faros_event.sh CI -k "<api_key>" \ | ||
| --artifact "<artifact_source>://<artifact_org>/<artifact_repo>/<artifact>" \ | ||
| --commit "<vcs_source>://<vcs_organization>/<vcs_repo>/<commit_sha>" \ | ||
| --pull_request_number "101" \ |
There was a problem hiding this comment.
can we allow --pull_request_number 101 ?
There was a problem hiding this comment.
Yes, it is allowed. Updated the README and added test
willmarks
approved these changes
Apr 12, 2022
|
nice! bump the version + release |
@willmarks promised to take care of that 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
About
Add ability to pass the pull request number associated with CI/CD event commit
Screenshots
Extras