FAI-5239: v2 flows not working #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) ensure pagination schemes for extract and flows are consistent
ypc-faros
approved these changes
Feb 17, 2023
tovbinm
approved these changes
Feb 17, 2023
|
kudos!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure pagination schemes for extract and flow queries are consistent.
We use pagination in 2 places in this library: (1) in extract queries and (2) flow queries. Since each v2 pagination process has its own id scheme (i.e. object ids are determined by the pagination process, not the underlying data) and we join data across extracts and flows, we need to ensure consistent usage across extracts and flows.
Type of change