Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #135

Merged
merged 4 commits into from
May 1, 2023
Merged

Update README.md #135

merged 4 commits into from
May 1, 2023

Conversation

tovbinm
Copy link
Contributor

@tovbinm tovbinm commented May 1, 2023

No description provided.

@tovbinm tovbinm requested a review from willmarks May 1, 2023 20:34
README.md Outdated
// The QueryBuilder manages origin for you
const qb = new QueryBuilder(ORIGIN);
// The QueryBuilder manages origin for you
const qb = new QueryBuilder(ORIGIN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in my PR but lets make this 'example-origin' or something as the const hasn't been defined yet in this snippet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to push to my branch and merge

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@willmarks willmarks merged commit 51a3d9a into main May 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants