FAI-6093: Handle different timestamp types in adapter #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
eskrm
commented
May 2, 2023
| @@ -757,7 +760,7 @@ describe('query adapter', () => { | |||
| status: {category: 'c1a', detail: 'd1a'} | |||
| }, | |||
| { | |||
| changedAt: 1667871145261, | |||
| changedAt: '2022-11-08T01:32:25.261Z', | |||
There was a problem hiding this comment.
Test a mix of epoch millis and ISO timestamps that are inside embedded object lists are converted to epoch millis.
eskrm
changed the title
ted-faros
approved these changes
May 2, 2023
| @@ -172,7 +176,7 @@ export function getFieldPaths( | |||
| // In V2, it's stored and typed like every other timestamp. | |||
| // We force conversion from ISO 8601 string => epoch millis | |||
| // string by overriding the type from string to timestamp. | |||
There was a problem hiding this comment.
I think it's accurate? This is pointing out an inconsistency in the v1 schema where refreshedAt is serialized as a timestamp, but is typed as a string. If we left the type as a string instead of overriding it, then we wouldn't convert the ISO timestamp to an epoch millis string.
There was a problem hiding this comment.
I think I was being too literal. The override type is now epoch_millis_string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.