FAI-4462: Move hasura schema dependencies to faros-js-client repo #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) sync this repo with PR#358 on feeds-sdk
|
@ypc-faros I did manual bump of version. Is that sufficient to get this published after merge? |
No need to bump. We publish the package to npm registry and the version is extracted from the release tag. |
ypc-faros
reviewed
Dec 2, 2022
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "faros-js-client", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
No need for this. Please revert
There was a problem hiding this comment.
@ted-faros we trigger releases from GitHub tags
ypc-faros
approved these changes
Dec 2, 2022
revert
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync
HasuraSchemaLoaderwith PR #358 fromfeeds-sdkType of change