New Docker Compose file & added X11 authentication compliance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2017
leonardofl
added a commit
to leonardofl/wscef-docker
that referenced
this pull request
Jun 26, 2017
I still dit not understand "in the same session will run ok, and not erase it." In the issue you explained about xauth, but not about your statement. It's strange to say "the container will run OK if you do not erase it", since if you "erase" the container, of course it will no be running OK (it will be erased). Sorry to be boring about that, but this container you created is amazing, and if it's used by people do not understand Docker (like me) the Readme can be really confusing. Anyway, considering the text in farribeiro#1, maybe my PR is OK.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include a Docker Compose file to make it easier to build and run the container. Execute
docker-compose buildto build the container anddocker-compose run wscefto run it.We also include X11 authentication compatibility in startup script. With these changes, one can surely start Firefox from the container if host system requires X11 authentication (if it doesn't, just drop variables
XAUTHORITYand/orHOST_HOSTNAMEfromenvironmentsection of Docker Compose file.We ensure startup script will work whether the container is running in host mode or not. In order to enable host mode in the container, just add
network_mode: 'host'towscefsection of Docker Compose file (equivalent to--net=hostoption ofdockercommand).