Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile #67

Merged
merged 6 commits into from
Feb 9, 2019
Merged

Fix Dockerfile #67

merged 6 commits into from
Feb 9, 2019

Conversation

andresmrm
Copy link
Contributor

@andresmrm andresmrm commented Feb 6, 2019 •
edited by farribeiro
Loading

Fix #59
Closes #39

@andresmrm
Copy link
Contributor Author

Parece que o arquivo certo para configurar os locales é o /etc/locale.gen e não /etc/locales.gen.
Demorei para perceber a diferença. Do jeito que estava não funcionava.
A doc confirma:
https://wiki.debian.org/Locale

@andresmrm
Copy link
Contributor Author

O Dockerfile estava com vários errinhos de estrutura e um problema na configuração das permissões de execução do startup.sh.

@diraol
Copy link
Contributor

diraol commented Feb 6, 2019

Boa!
Fiz isso numa correria danada e esses erros acabaram passando entre um rebase e outro para deixar os commits mais organizados.

Outra coisa @andresmrm rola você adicionar --class CaixaEconomica --name CaixaEconomica na linha 27 do startup.sh para incorporar a alteração do PR #39 ? (Isso vai ajudar a controlar a janela em vários casos, inclusive para quem usa i3wm.) ;)

@andresmrm
Copy link
Contributor Author

Feito! =)

farribeiro
farribeiro requested changes Feb 9, 2019
View reviewed changes
Copy link
Owner

@farribeiro farribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solicito alterações em relação a permissão dos scripts

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@farribeiro farribeiro added the P3 Prioridade Alta label Feb 9, 2019
@farribeiro farribeiro merged commit 02fa258 into farribeiro:master Feb 9, 2019
@farribeiro farribeiro mentioned this pull request Feb 9, 2019
Merged
@farribeiro
Copy link
Owner

Link #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diraol diraol diraol left review comments

@farribeiro farribeiro farribeiro approved these changes

Assignees
No one assigned
Labels
P3 Prioridade Alta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andresmrm @diraol @farribeiro