TD title matching instead of JSON comparison #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreaCimminoArriaga @ethieblin @Murloc6 please review. |
|
Ok for me, I agree that it would be a good thing to add a few tests on JSON-LD expanded objects (and/or on JSON-LD framing with a few flexibilities). Shall I add an issue for that ? |
Sure. Please do so. Thanks |
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison of the mock TD input and output from directory was done by serializing the objects to JSON and performing a bytes comparison. This was subject to failure when the directory was performing semantic processing and giving the output in another semantically equivalent representation. I replacing this with a simple
titlecheck. This is okay because the tests aren't really about making sure the directory returns the exact TD, but rather about making sure the workflows are based on specified assertion. Fine grained tests on exact input and matching output should be done independently as unit tests.We could perform comparison on expanded JSON-LD objects, if someone can come up with a working solution.