changed batch to return [] when count is invalid

farzher · Aug 3, 2014 · d441b4f · d441b4f
1 parent eeb5c0f
commit d441b4f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/browser.min.js b/browser.min.js
diff --git a/index.js b/index.js
diff --git a/index.ls b/index.ls
@@ -48,8 +48,8 @@ _.where = (query, list) ->
 	, list
 
 _.batch = (count, list) ->
-	count = Number count; if count < 1 => count = 1
-	list = _.clone list
+	count = Number count; if count < 1 => return []
+	list = list.slice 0
 	return (while list.length => list.splice 0, count)
 
 

diff --git a/test/test.js b/test/test.js
diff --git a/test/test.ls b/test/test.ls
@@ -53,5 +53,5 @@ exports import
 		it.strictEqual (_.batch 2, list).length, list.length / 2
 		it.strictEqual (_.batch 1, list).length, list.length
 		it.strictEqual (_.batch list.length, list).length, 1
-		it.strictEqual (_.batch '-1', list).length, list.length, 'Batching by a broken amount should default to batching by 1'
+		it.strictEqual (_.batch '-1', list).length, 0, 'Batching by a broken amount should return []'
 		it.done!