New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takeoff documentation #490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 130 130
Lines 6005 6005
Branches 885 885
=======================================
Hits 5065 5065
Misses 784 784
Partials 156 156
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cc133c8
to
568aedd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the documentation. I just noticed the name of one takeoff parameter sounds wrong. The rest seems ok to me.
rotation_rate: | ||
value: 0.0523 | ||
units: rad | ||
rotation_alpha_limit_truc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this parameter sounds wrong, or still in a 'temporary' state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed in 0939b08 with some other minor problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
This PR updates Sphinx doc regarding recent takeoff additions.
Preview available here : https://fast-oad.readthedocs.io/en/takeoff-documentation/documentation/mission_module/mission_file/segments.html
Also, some fixes in documentation have been added.