Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takeoff documentation #490

Merged
merged 4 commits into from Apr 26, 2023
Merged

Takeoff documentation #490

merged 4 commits into from Apr 26, 2023

Conversation

christophe-david
Copy link
Contributor

@christophe-david christophe-david commented Apr 24, 2023

This PR updates Sphinx doc regarding recent takeoff additions.
Preview available here : https://fast-oad.readthedocs.io/en/takeoff-documentation/documentation/mission_module/mission_file/segments.html

Also, some fixes in documentation have been added.

@christophe-david christophe-david marked this pull request as ready for review April 24, 2023 14:17
@christophe-david christophe-david marked this pull request as draft April 24, 2023 14:19
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #490 (0939b08) into master (a76be73) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         130      130           
  Lines        6005     6005           
  Branches      885      885           
=======================================
  Hits         5065     5065           
  Misses        784      784           
  Partials      156      156           
Impacted Files Coverage Δ
...toad/models/performances/mission/polar_modifier.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christophe-david christophe-david marked this pull request as ready for review April 24, 2023 14:43
Copy link
Collaborator

@esnguyenvan esnguyenvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the documentation. I just noticed the name of one takeoff parameter sounds wrong. The rest seems ok to me.

rotation_rate:
value: 0.0523
units: rad
rotation_alpha_limit_truc:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this parameter sounds wrong, or still in a 'temporary' state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed in 0939b08 with some other minor problems.

Copy link
Collaborator

@esnguyenvan esnguyenvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@christophe-david christophe-david merged commit 8a567ad into master Apr 26, 2023
15 checks passed
@christophe-david christophe-david deleted the takeoff-documentation branch April 26, 2023 09:16
@christophe-david christophe-david mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants