-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Suggested Fixes #30
Comments
Can you create pull request for this? checkout master branch and apply your patch, double check for changes and create pull request (p.s. master branch is the development one) |
Sure, I can do that if you’d like. It may take me a few days since I’m off for the holidays though.
Would that be alright?
From: Justas Balčas [mailto:notifications@github.com]
Sent: Wednesday, December 13, 2017 9:02 AM
To: fast-data-transfer/fdt <fdt@noreply.github.com>
Cc: wkwood <wkwood@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [fast-data-transfer/fdt] Windows Suggested Fixes (#30)
Can you create pull request for this? checkout master branch and apply your patch, double check for changes and create pull request (p.s. master branch is the development one)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#30 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AEd0AIcC-OKmo-FcL5YhEm7y8hc8h89Xks5s_-bRgaJpZM4RAnmZ> . <https://github.com/notifications/beacon/AEd0AGWFa__PLtRDykujov_jT17Svoy0ks5s_-bRgaJpZM4RAnmZ.gif>
|
Hi, Would this address the issue when I use the filelist in Windows in that it can't create the parent directories? Is there a way to suppress the attempt to create the parent directories? Mark |
Answering my own question here, but applying the patch did indeed seem to resolve the issue with the filelist. Thanks! |
Thank you for creating the patch file. Is there a time frame when the new version of FDT will be available? From my testing, I notice that the suggested changes will resolve an issue where FDT + GSI in server mode use up a lot of CPU after each transfer. |
* applied patchfile.txt from issue #30 upstream * bugfix for directory separator / instead of : * adding support for -shell command line option * adding support for customShell * increase for expected number of arguments Co-authored-by: Nicholas Hadaway - c002286 <Nicholas.Hadaway@footlocker.com> Co-authored-by: Raimondas Širvinskas <raimis.sirvis@gmail.com>
I'd like to submit this patchfile that I've developed against 0.26.1 for Windows. It cleans up quite a few problems we were seeing. I can document these further if you'd like.
patchfile.txt
The text was updated successfully, but these errors were encountered: