Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A cool little detail... #1613

Closed
dAtA-TRoN opened this issue Apr 23, 2024 · 5 comments
Closed

A cool little detail... #1613

dAtA-TRoN opened this issue Apr 23, 2024 · 5 comments
Labels
enhancement New feature or request implemented Feature or request have been developed

Comments

@dAtA-TRoN
Copy link

dAtA-TRoN commented Apr 23, 2024

Description

Currently, RiMusic utilizes highlighted navigation elements to indicate the active tab, ensuring users know their current location within the app:

IMG_20240423_060513

With the recent addition of a new window featuring History, Statistics, and Settings entries, there's an opportunity to add a subtle yet charming detail to the icons associated with these sections.

Implementing a feature where these icons are also highlighted when their respective tabs are active would not only add a delightful touch but also enhance the coherence of the app's design language:

ZomboDroid_23042024060729

@dAtA-TRoN dAtA-TRoN added the enhancement New feature or request label Apr 23, 2024
@fast4x
Copy link
Owner

fast4x commented Apr 23, 2024

Maybe is just implemented in version 0.6.32.
IMG_20240423_081514.jpg

@dAtA-TRoN
Copy link
Author

dAtA-TRoN commented Apr 23, 2024

First off, kudos for thinking about it 💐😃 -nice touch!

But from what I can gather in your screenshot, it's a tad confusing for me. It seems to be working exactly the opposite of how it does in the rest of the app, right? I mean, everywhere else in the app, the tab icon gets highlighted where you currently are. Isn't that a bit peculiar? Please don't get upset right away that I can only complain. I believe I might be onto something here 😅.

@fast4x
Copy link
Owner

fast4x commented Apr 23, 2024

I can’t get angry, I change the colors and it’s okay...

@fast4x
Copy link
Owner

fast4x commented Apr 23, 2024

Screenshot_20240423_113822

@dAtA-TRoN
Copy link
Author

Well, it's not exactly what I had in mind, but it seems we're just seeing things from different angles. And since I don't want to make a mountain out of a molehill, I'll leave it at that. It's definitely an improvement though, that much is certain 😊.

@fast4x fast4x added the implemented Feature or request have been developed label Apr 30, 2024
@fast4x fast4x closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

2 participants