Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyway to get this app via Fdroid? #201

Closed
Driftinginfinitely opened this issue Dec 10, 2023 · 21 comments
Closed

Is there anyway to get this app via Fdroid? #201

Driftinginfinitely opened this issue Dec 10, 2023 · 21 comments
Labels
enhancement New feature or request implemented Feature or request have been developed

Comments

@Driftinginfinitely
Copy link

Description

Is this app available via Fdroid? If not, is it likely to be available there in the future?

Suggested Solution

Alternatives

No response

Additional Context

No response

@Driftinginfinitely Driftinginfinitely added the enhancement New feature or request label Dec 10, 2023
@fast4x
Copy link
Owner

fast4x commented Dec 10, 2023

Yes, Publication on FDroid is ongoing

@OrangeZXZ
Copy link

This issue can be closed because there is already an existing one:
#9 (comment)

@IzzySoft
Copy link

While on it, please check your Fastlane changelogs. Per definitionem, their maximal size is 500 characters each – 6.txt has about 2k, that's 4 times as much, so it will be truncated midword at position 500. Those per-release changelogs should only hold the highlights, but you can include a link to the full changelog when needed.

While there, you might also wish to include an introducing paragraph at the start of full_description.txt – like what you have in your Readme, or even a bit more detailed.

Meanwhile, with the next sync around 7 pm UTC your app will become available here in my repo, and look like this:

image

Which also tells you about 2 current show-stoppers for inclusion with F-Droid, which does not allow proprietary components.

@fast4x
Copy link
Owner

fast4x commented Dec 15, 2023

Già che ci sei, controlla i log delle modifiche di Fastlane. Per definizione, la loro dimensione massima è di 500 caratteri ciascuno - ha circa 2k, che è 4 volte tanto, quindi sarà troncato a metà parola alla posizione 500. Questi changelog per rilascio dovrebbero contenere solo i punti salienti, ma è possibile includere un collegamento al changelog completo quando necessario.6.txt

Mentre sei lì, potresti anche voler includere un paragrafo introduttivo all'inizio, come quello che hai nel tuo Readme, o anche un po' più dettagliato.full_description.txt

Nel frattempo, con la sincronizzazione successiva intorno alle 19:00 UTC, l'app lo farà become available here nel mio repository e assomiglia a questo:

image

Che ti dice anche di 2 attuali show-stopper per l'inclusione con F-Droid, che non consente componenti proprietari.

Hi Izzy, thank you so much!
I will do the checks and accommodations you indicated, but Cronet is no longer there, I have removed it and replaced it with non-proprietary library.

@IzzySoft
Copy link

I will do the checks and accommodations you indicated

Thanks a lot! Once in place, please give me a ping so I can cross-check and adjust here accordingly (e.g. enable pulling changelogs, trigger an update for fulldesc etc). My repo operates a little different from F-Droid.org 😉

Cronet is no longer there

My library scanner still detects it. Does the replacement use the same "signature" (like, packageName, directory structure etc) – and can you give a link to its sources? Same for GMS?

@fast4x
Copy link
Owner

fast4x commented Dec 15, 2023

I will do the checks and accommodations you indicated

Thanks a lot! Once in place, please give me a ping so I can cross-check and adjust here accordingly (e.g. enable pulling changelogs, trigger an update for fulldesc etc). My repo operates a little different from F-Droid.org 😉

Cronet is no longer there

My library scanner still detects it. Does the replacement use the same "signature" (like, packageName, directory structure etc) – and can you give a link to its sources? Same for GMS?

This is the library I use to translate lyrics. This may be reported.

https://github.com/therealbush/translator

@IzzySoft
Copy link

This is the library I use to translate lyrics. This may be reported.

Nope. Reported is Cronet , which is detected by the path /com/google/android/gms/net (or the packageName com.google.android.gms.net). Your translator would be /me/bush/translator (me.bush.translator). That would be NonFreeComp as well as it has no license declared (and also NonFreeNet as it uses Google Translator APIs).

@fast4x
Copy link
Owner

fast4x commented Dec 16, 2023

ok I check better, thanks

@fast4x
Copy link
Owner

fast4x commented Dec 16, 2023

This is the library I use to translate lyrics. This may be reported.

Nope. Reported is Cronet , which is detected by the path /com/google/android/gms/net (or the packageName com.google.android.gms.net). Your translator would be /me/bush/translator (me.bush.translator). That would be NonFreeComp as well as it has no license declared (and also NonFreeNet as it uses Google Translator APIs).

Found It!
Isn't a library but two meta data in Android manifest

    <meta-data android:name="com.google.android.gms.car.application"
        android:resource="@xml/automotive_app_desc"/>

    <meta-data android:name="com.google.android.gms.car.notification.SmallIcon"
        android:resource="@drawable/app_icon" />

@IzzySoft
Copy link

It's not just an entry in the manifest. See here:

image

(smali generated by Apktool, showing the libraries) Could be "dragged in" as a dependency by some other library. To find out, you can use e.g. gradle :app:dependencies

@fast4x
Copy link
Owner

fast4x commented Dec 16, 2023

Thanks

@IzzySoft
Copy link

Yay, success! with the next sync, the NonCreeComp will be gone 🥳

@fast4x
Copy link
Owner

fast4x commented Dec 17, 2023

Yay, success! with the next sync, the NonCreeComp will be gone 🥳

The repo has updated, the list of libraries does not contain Gms, but NonFreeComp remained.

Do I have to do something?

@IzzySoft
Copy link

Do I have to do something?

Yes: Have patience for another ~4 hours 😉 As I wrote:

with the next sync …

Syncs happen daily around 7 pm UTC (winter; in summer 6 pm UTC).

@fast4x
Copy link
Owner

fast4x commented Dec 17, 2023

Ahhhh ok i’m sorry

@IzzySoft
Copy link

No prob. The "small-print" gets each of us at least once 🙈

@fast4x
Copy link
Owner

fast4x commented Dec 24, 2023

Also published on F-Droid.

@fast4x fast4x closed this as completed Dec 24, 2023
@IzzySoft
Copy link

Also published on F-Droid.

Congrats to the listing! At this point apps are usually removed from my repo, after a decent overlap (of about 2 weeks). You're ready for that?

@fast4x
Copy link
Owner

fast4x commented Dec 28, 2023

I thought it was kept in your repo too. Can’t you keep it? I’d be honored!

@IzzySoft
Copy link

Default is removal. But as 1) your app is relatively small (< 5 MB APK-size), you 2) established reproducible builds and 3) explicitly requested it to stay, I've marked it for this exception so it will stay.

@fast4x
Copy link
Owner

fast4x commented Dec 28, 2023

Thank you very much

@fast4x fast4x added implemented Feature or request have been developed and removed In progress labels Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

4 participants