Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default command for installing libraries #271

Merged
merged 1 commit into from Jun 6, 2019

Conversation

mariokostelac
Copy link
Contributor

Installing libraries from python notebooks is actually not easy, but this should work for everybody whose user has access to site-packages.

Installing libraries from python notebooks is actually not easy, but this should work for everybody whose user has access to site-packages.
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/fastai/course-v3/pull/271

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@jph00
Copy link
Member

jph00 commented May 9, 2019

Can you please explain why the longer conda one is needed?

@mariokostelac
Copy link
Contributor Author

Sure. Because Jupyter kernels can be added different ways (manually or with nbconda extension), it's not always the case that conda environment variables are set properly (for example, some SageMaker environments are configured that way). Passing --prefix just makes it explicit where to install packages.

@jph00 jph00 merged commit 19682ee into fastai:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants