Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(04): pred typo #22

Merged
merged 3 commits into from May 4, 2023

Conversation

williamsk91
Copy link
Contributor

@williamsk91 williamsk91 commented May 3, 2023

@jph00 First time making a PR here, please tell me anything I can improve on 馃檱

@review-notebook-app
Copy link

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented May 3, 2023

Many thanks! We don't aim to support running the notebooks in isolation - they're designed to run in order. So please remove the added code that downloads MNIST here.

@williamsk91
Copy link
Contributor Author

Thanks for the quick reply! I've removed them

@williamsk91 williamsk91 changed the title fix(04): pred typo and missing mnist import fix(04): pred typo May 4, 2023
@jph00
Copy link
Member

jph00 commented May 4, 2023

Many thanks!

@jph00 jph00 merged commit df93232 into fastai:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants