Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Callback which has the same name as an attribute no longer raises an exception #3109

Closed
jph00 opened this issue Dec 28, 2020 · 0 comments
Labels

Comments

@jph00
Copy link
Member

jph00 commented Dec 28, 2020

When you add, for example, a callback called Foo to a Learner, it makes that available in the foo attribute of the learner.

Previously, if you added a Foo callback to a learner that already had a foo attribute, that would raise an exception. However, since it's not possible to know what other callbacks exist and what attributes might be added to a learner, we've now removed the code that raises an exception.

@jph00 jph00 added the breaking label Dec 28, 2020
@jph00 jph00 closed this as completed in b31cf94 Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant