Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed dataloaders arguments to have consistent overrides #3178

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Changed dataloaders arguments to have consistent overrides #3178

merged 1 commit into from
Feb 8, 2021

Conversation

marii-moe
Copy link
Collaborator

Fixes #3133

@marii-moe marii-moe requested a review from jph00 as a code owner January 20, 2021 10:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented Feb 8, 2021

Thank you! :)

@jph00 jph00 changed the title Changed dataloaders arguements to have consistent overrides Changed dataloaders arguments to have consistent overrides Feb 8, 2021
@jph00 jph00 merged commit d044835 into fastai:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jph00 jph00 Awaiting requested review from jph00 jph00 is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataBlock.dataloaders does not support the advertised "shuffle" argument
2 participants
@marii-moe @jph00