New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase testing granularity for speedup #3242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 9 batches instead of 3
ddobrinskiy
changed the title
increase testing granularity
Increase testing granularity for speedup
Mar 6, 2021
Hmmm, not sure what the problem is. The tests fail for nbs/04_data.external.ipynb saying that file is not found, full traceback below. The CALTECH url is reachable at the moment. https://s3.amazonaws.com/fast-ai-imageclas/caltech_101.tgz Reading from the notebook, I get a feeling that maybe this cell should not be present anyway?
|
URLs.CALTECH_101 this cell looks like it should not be here
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 9 batches instead of 3:
Current setup of 3 batches means that 20+ notebooks fall into the [5-7] batch and it takes 9minutes to test all the notebooks, example: https://github.com/fastai/fastai/pull/3235/checks?check_run_id=1969103831
With minimal code changes, we can split notebooks into 9 batches instead of 3, which should speed-up testing
upd: with new configuration, actual notebook testing takes at most 1m20s (excluding docker setup, cache download, et cetera)