Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of new DataLoader in Learner.get_preds has wrong keyword #3316

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Creation of new DataLoader in Learner.get_preds has wrong keyword #3316

merged 2 commits into from
Apr 30, 2021

Conversation

tcapelle
Copy link
Contributor

@tcapelle tcapelle commented Apr 12, 2021

Typo on shuffled attr on Learner

Don't know if there is a way to test that non-existant kwargs raise an exception.

@tcapelle tcapelle requested a review from jph00 as a code owner April 12, 2021 13:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@muellerzr
Copy link
Contributor

muellerzr commented Apr 16, 2021

cc @jph00 this looks fine to me. The reason this never popped up any tests is shuffle is set to False by default, so it was still generating a non-shuffled DataLoader. Just instead the wrong param was exposed. (Which is a non-existant one)

@tcapelle
Copy link
Contributor Author

tcapelle commented Apr 18, 2021

My question was about exposing a non-existant param. Shouldn't calling a method/func with a non-existant kwargs raise an error?
Here we are calling DataLoader.new with a kwargs that does not exists, how can we make this fail.

@jph00
Copy link
Member

jph00 commented Apr 30, 2021

Many thanks!

@jph00 jph00 merged commit 880e142 into fastai:master Apr 30, 2021
@jph00 jph00 changed the title Fix 3312 Creation of new DataLoader in Learner.get_preds has wrong keyword Apr 30, 2021
@jph00 jph00 added the bug label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants