Fix PixelShuffle_icnr weight

[pratX]

When using weight_norm (the current default), PixelShuffle_icnr needs to icnr_init weight_g and weight_v.
Issue #3315

[pratX]

Work in Progress. Checking out nbdev and following the development process used for fastai.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[pratX]

Updated the notebook with the fix and also the unit test. The unit test passes with weight_norm enabled (earlier weight_norm was explicitly disabled in the unit test, even though the description said that weight_norm is what worked best with super_resolution) which is the expected behavior.

[pratX]

Updated PixelShuffle_icnr unit test to check for both cases, weight_norm enabled and disabled. Both the unit tests pass.

[tcapelle]

Would you mind adding the spectral norm init also?

…

On Thu, Apr 15, 2021, 8:50 AM pratX ***@***.***> wrote: Updated PixelShuffle_icnr unit test to check for both cases, weight_norm enabled and disabled. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3322 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEMWOAK4ANPJKXU26YDGKX3TI2EDDANCNFSM42542OBA> .

[pratX]

Would you mind adding the spectral norm init also?
…
On Thu, Apr 15, 2021, 8:50 AM pratX @.***> wrote: Updated PixelShuffle_icnr unit test to check for both cases, weight_norm enabled and disabled. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3322 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMWOAK4ANPJKXU26YDGKX3TI2EDDANCNFSM42542OBA .

Added unit test for PixelShuffle_icnr with sepctral_norm.

[tcapelle]

graet!

[jph00]

Many thanks!