Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to use raw pytorch DataLoaders #3328

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Fix ability to use raw pytorch DataLoaders #3328

merged 3 commits into from
Apr 21, 2021

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Apr 21, 2021

This PR reverts #3253 to fix #3324 and adds a small test as well to verify that the device attribute exists.

We also bump the version of torchvision to 0.8.2 so that the migrating from pytorch example notebook works without error.

cc: @muellerzr @jph00

@hamelsmu hamelsmu requested a review from jph00 as a code owner April 21, 2021 22:47
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu added the bug label Apr 21, 2021
@hamelsmu hamelsmu merged commit 41e5e9c into master Apr 21, 2021
@hamelsmu hamelsmu deleted the fix-3324 branch April 21, 2021 23:13
@hamelsmu hamelsmu changed the title fix #3324 Fix ability to use raw pytorch DataLoaders Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking: Can no longer use raw torch DataLoaders with fastai
1 participant