Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order to TrackerCallback derived classes #3346

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Add order to TrackerCallback derived classes #3346

merged 1 commit into from
Apr 30, 2021

Conversation

muellerzr
Copy link
Contributor

Originally based on #3319

Sets each derived TrackerCallback to have specific orders so that each cannot interfere with each other, and the order is logical in regards to when each event should occur.

Also included documentation on their orders along with the Callback's actual order val

cc @jph00

@muellerzr muellerzr requested a review from jph00 as a code owner April 30, 2021 23:38
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00 jph00 merged commit 584623a into fastai:master Apr 30, 2021
@jph00 jph00 added the bug label Apr 30, 2021
@hamelsmu hamelsmu changed the title Give explicit orders to TrackerCallback derived Callbacks Add order to TrackerCallback derived classes Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants