Check if normalize exists on _add_norm
#3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Very nice fix and test! cc: @jph00 |
jph00
requested changes
May 16, 2021
Co-authored-by: Jeremy Howard <github@jhoward.fastmail.fm>
Co-authored-by: Jeremy Howard <github@jhoward.fastmail.fm>
|
Ready to go @jph00, updated with your suggestions. |
|
I’ve been made aware of that this only adds Normalize to the train, not the
validation. Can you confirm this Renato? And perhaps maybe we can fix that
here?
…On Sun, May 16, 2021 at 6:38 AM Renato Hermoza Aragonés < ***@***.***> wrote:
Ready to go @jph00 <https://github.com/jph00>, updated with your
suggestions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3371 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3YCV6EKPBAMEY54CAM763TN6OARANCNFSM44YI2HVA>
.
|
|
@muellerzr I just tried and it was working fine. Can you share and example of that happening? |
|
@renato145 thanks for the verification, I believe this may have also been fixed in this latest version (the issue opened up on the forums). Also looks like notebooks and the lib aren't synced. Can you run |
|
Many thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3370