send self.loss_func to device if it is an insatnce on nn.Module #3395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
loss_func
has assoicated parameters or buffers on other device it triggers error. This PR adds a line to sendloss_func
to device inTrainEvalCallback
is it's an instance ofnn.Module
.Minimal example gist: https://gist.github.com/arampacha/ae6299a7b577da3d2d18e88bec2e39e2
If this makes sense it's possible to add
BaseLoss.to
method and have similar behavior for it