Fix concurrent LRFinder instances overwriting each other by using tempfile #3528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3415 and resolves #3240 by saving model to
TemporaryDirectory
under learner path/model_dir.Tested on Linux and Windows.
If preferred, I can update the PR to use
TemporaryDirectory
as a context manager inlr_find
and pass the temp_dir name toLRFinder
.Notes:
is required as path/model_dir might not exist yet. And
exists because
self.tmp_d.name
returns model_dir/tempfolder.