Fix Classification Interpretation #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jph00
requested changes
Jan 25, 2022
nbs/20_interpret.ipynb
Outdated
| @@ -8,7 +8,7 @@ | |||
| "source": [ | |||
| "#hide\n", | |||
| "#skip\n", | |||
| "! [ -e /content ] && pip install -Uqq fastai # upgrade fastai on colab" | |||
| "# ! [ -e /content ] && pip install -Uqq fastai # upgrade fastai on colab" | |||
There was a problem hiding this comment.
Could you please uncomment this? It's needed to work on colab
|
Done |
|
Great. |
|
@warner-benjamin With the changes made here, one would be re-running inference on each call of plotting the confusion matrix or fetching the |
|
@rsomani95 It's on my todo list to add back a cached option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3562 and adds simple test to make sure
ClassificationInterpretationdoesn't fall through the cracks again.Implementation does generate the entire datasets' worth of predictions, targets, and decoded predictions, which is required for the confusion matrix. It might be possible to make this more memory efficient, but the labels and predictions for classification problems are not usually that large.