Fixing ColReader #3602
Merged
Fixing ColReader #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a similar issue as #3164 with a column named
'mask'. This time, it was a conflict with DataFrame's function calledmask(https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.mask.html).Here is an example I took from a tutorial that uses ColReader to reproduce the issue:
https://gist.github.com/hiromis/e371603e71543cd7cca9cea7dfcc7609
I could have added 'mask' to a list of special cases along with 'name' and 'cat', but I thought checking whether
ris a namedtuple containing a fieldcmay be cleaner.The existing tests ran fine, and I also did a sanity check using the example notebook:
https://gist.github.com/hiromis/7a0863072694faa5a0f6fb0bbcb3d2da