Integrate nested callable and getcallable #3691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Nested Callable from fastcore
What does this add?
This PR merges the recent nested callable addition to fastcore into fastai.
Why is it needed?
The fastai codebase has multiple counts of a duplicated pattern:
We can instead use
getcallable
andnested_callable
to remove thatnoop
and call it implicitly.This PR also changes
in_channels
to return the rightStopIteration
exception and just modifies the message, rather than a rawException
class.What parts of the API does this impact?
User-facing:
Nothing they will see
Internal structure:
All instances following the above pattern have been replaced with
nested_callable
orgetcallable
cc @jph00