Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for pretrained in vision.learner #3746

Closed

Conversation

peterdudfield
Copy link

fix for pretrained in vision.learner

Make sure input is pretrained=pretrained

#3745

@jph00
Copy link
Member

jph00 commented Jul 25, 2022

Thanks @peterdudfield . This is an nbdev project so fixes need to be made in notebooks and then the lib built from there. I'll fix it at our end to save you the trouble.

@jph00 jph00 closed this Jul 25, 2022
@peterdudfield
Copy link
Author

Thanks @jph00 , please let me know the commit, I would be interested to see how it is done

@peterdudfield
Copy link
Author

I think ive done it here

Screenshot 2022-07-25 at 23 00 23

@jph00
Copy link
Member

jph00 commented Jul 25, 2022

Thanks @peterdudfield -- I'm actually in the middle of updating fastai to work with nbdev2 and included your commit in that, so it'll be a while before it's visible! Your image looks like you figured it out though :)

@peterdudfield
Copy link
Author

Thanks @peterdudfield -- I'm actually in the middle of updating fastai to work with nbdev2 and included your commit in that, so it'll be a while before it's visible! Your image looks like you figured it out though :)

Thanks, and good luck changing it to nddev2. Its the first time ive seen this setup with notebooks, and then testing the notebooks. Looks good.

@jph00
Copy link
Member

jph00 commented Jul 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants