Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes fastai/fastai#3981 to stop deprecated warning messages #3994

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

jkyamog
Copy link
Contributor

@jkyamog jkyamog commented Dec 15, 2023

I have used the current torch.backends.mps.is_built attribute to replace the older has_mps has been deprecated about 6 months ago on this pytorch commit

I have tested on an M1 machine for the positive case should the mps.is_available (line above) return false. I have also tested this on a x86/nvidia machine and it remove the warning signs.

I have attached here a screenshot on how it can look like on google collab when its not fixed.
Screenshot 2023-12-15 at 15 22 35

@jkyamog jkyamog requested a review from jph00 as a code owner December 15, 2023 04:35
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented Jan 7, 2024

Many thanks!

@jph00 jph00 merged commit 43dbef3 into fastai:master Jan 7, 2024
28 checks passed
@jkyamog jkyamog deleted the fix_for_mps_deprecated_warning branch January 7, 2024 23:34
@jkyamog jkyamog restored the fix_for_mps_deprecated_warning branch January 7, 2024 23:34
@jkyamog jkyamog deleted the fix_for_mps_deprecated_warning branch January 7, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants