Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skimage missing in README #300

Closed
KeremTurgutlu opened this issue Nov 17, 2019 · 2 comments · Fixed by #306
Closed

skimage missing in README #300

KeremTurgutlu opened this issue Nov 17, 2019 · 2 comments · Fixed by #306

Comments

@KeremTurgutlu
Copy link

Note in README.md "To use fastai2.medical.imaging you'll also need to:" is missing skimage dependency.
@sgugger
Copy link
Contributor

sgugger commented Nov 19, 2019

I never got a complain on a fresh install, isn't it automatically installed by some of the other dependency?

@KeremTurgutlu
Copy link
Author

KeremTurgutlu commented Nov 21, 2019 •
edited
Loading

Following the steps:

  1. clone https://github.com/fastai/fastai_dev/
  2. cd to fastai_dev
  3. conda env create -f environment.yml
  4. conda activate fastai_dev
  5. conda install pyarrow
  6. pip install pydicom kornia opencv-python
  7. python run_notebook.py --fn 60_medical_imaging.ipynb

looks like scikit-image library is not dependency of any of the others

brettkoonce added a commit to brettkoonce/fastai_docs that referenced this issue Nov 22, 2019
@brettkoonce
add scikit-image dep
3fd43ea 
Closes fastai#300.
@brettkoonce brettkoonce mentioned this issue Nov 22, 2019
Merged
sgugger pushed a commit that referenced this issue Nov 23, 2019
@brettkoonce @sgugger
add scikit-image dep (#306)
a773deb 
Closes #300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add scikit-image dep brettkoonce/fastai_docs
2 participants
@KeremTurgutlu @sgugger