Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug in _oper #111

Closed
Salehbigdeli opened this issue Oct 7, 2020 · 0 comments
Closed

Minor bug in _oper #111

Salehbigdeli opened this issue Oct 7, 2020 · 0 comments

Comments

@Salehbigdeli
Copy link
Contributor

Salehbigdeli commented Oct 7, 2020

In the definition of _oper there is an assumption about the third argument. If it's not equal to the default it assumes that we want to use op in partial case.

Failing example:

assert math.isnan(add(1, float('nan')))

We also can't use None as default in _oper, at least for getting more useful error messages.

@Salehbigdeli Salehbigdeli changed the title Minor bug-fix Minor bug in _oper Oct 7, 2020
@jph00 jph00 closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants