@typedispatch does not support default values

[antorsae]

@typedispatch
def f_td_test(x:int, y:int=10): return x*y

test_eq(f_td_test(3,2), 6)
test_eq(f_td_test(3), 30)

Errs out:

---------------------------------------
TypeErrorTraceback (most recent call last)
<ipython-input-34-6e7b98db6be2> in <module>
      3 
      4 test_eq(f_td_test(3,2), 6)
----> 5 test_eq(f_td_test(3), 30)

<ipython-input-12-9fc191b1d495> in __call__(self, *args, **kwargs)
     34         if not f: return args[0]
     35         if self.inst is not None: f = MethodType(f, self.inst)
---> 36         return f(*args, **kwargs)
     37 
     38     def __get__(self, inst, owner):

TypeError: f_td_test() missing 1 required positional argument: 'y'

[jph00]

Are you interested enough in this to have a go at fixing it? Because I'm not likely to, unless I really need it... ;)

[antorsae]

Just submitted a PR adding a warning.

…

On Sun, Aug 30, 2020, 01:37 Jeremy Howard ***@***.***> wrote: Are you interested enough in this to have a go at fixing it? Because I'm not likely to, unless I really need it... ;) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALSJSR3SBAXFLUY4WJ235DSDGGK7ANCNFSM4QOTSCQQ> .

[jph00]

Closing this since we have a workaround.