Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_eq incorrect for pandas DataFrame #188

Merged
merged 4 commits into from Dec 21, 2020

Conversation

kessido
Copy link
Contributor

@kessido kessido commented Nov 11, 2020

Hey, I notice that pandas test_eq is incorrect.
I added a test to see that it always return True, and that it doesn't actually fail when given wrong inputs.
Instead I added a call for .equals which is implemented in pd.Series\pd.DataFrame.

This resulted in a failing test now, which I fixed.

Ido

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kessido
Copy link
Contributor Author

kessido commented Nov 11, 2020

integration test fail because it should P: pandas doesnt support this comparison.

>>> import pandas as pd
>>> a = pd.Series([1,2,3,4])
>>> b = [1,2,3,4]
>>> a.equals(b)
False

@jph00 jph00 merged commit f8243df into fastai:master Dec 21, 2020
@jph00 jph00 changed the title Fix pandas test eq test_eq incorrect for pandas DataFrame Dec 21, 2020
@jph00 jph00 added the bug Something isn't working label Dec 21, 2020
@kessido kessido deleted the fix_pandas_test_eq branch December 22, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants