Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastcore.style: fast styling for friendly CLIs #460

Merged
merged 1 commit into from Aug 10, 2022
Merged

Conversation

seeM
Copy link
Member

@seeM seeM commented Aug 10, 2022

@seeM seeM added the enhancement New feature or request label Aug 10, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented Aug 10, 2022

I like it! Two suggestions:

  1. Inherit from, or (maybe better?) compose, list, not L, to avoid dep on foundation
  2. Put this in its own module -- since it'll be used in a lot of CLIs, we want it fast, so no reason to import all of xtras

Also, can you check whether Quarto now supports ansi terminal escapes? If it does, we should stop removing them all in processors.py.

@seeM
Copy link
Member Author

seeM commented Aug 10, 2022

@jph00 Done, I like your suggestions! In my testing, it doesn't seem like Quarto supports ansi terminal escapes yet.

@seeM seeM changed the title Add minimal terminal text styling to xtras Add fastcore.style: fast styling for friendly CLIs Aug 10, 2022
@jph00 jph00 merged commit c95818d into fastai:master Aug 10, 2022
@seeM seeM deleted the style branch August 10, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants