Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Noise Leaderboards README.md #41

Merged
merged 9 commits into from
Feb 6, 2021
Merged

Add Noise Leaderboards README.md #41

merged 9 commits into from
Feb 6, 2021

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Feb 6, 2021

Related to #40

@tmabraham do you mind sanity checking these for me?

cc: @jph00

@hamelsmu hamelsmu mentioned this pull request Feb 6, 2021
4 tasks
@tmabraham
Copy link
Contributor

Don't you need to have an additional URL column?

Copy link
Contributor

@tmabraham tmabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems for 50% column the table is broken now (checking the rich diff)? Also, I don't think we need the Imagewoof column, I think it's understood it's the Imagenette dataset. Finally, there's a # Runs column for the imagenette leaderboards, which probably should be added here too. All of my baselines are single runs (might run more in the future).

Hamel Husain and others added 2 commits February 5, 2021 23:33
@hamelsmu
Copy link
Member Author

hamelsmu commented Feb 6, 2021

ok good catch! I fixed those just now!

Copy link
Contributor

@tmabraham tmabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In keeping with the previous Imagenette leaderboards
Size --> Size (px)
Runs --> # Runs
Accuracy probably should have the percentage instead of the decimal (my fault as I should have reported it as such, sorry!)

These are minor issues, but thought I would point it out. Hope I am not nitpicking too much!

@hamelsmu
Copy link
Member Author

hamelsmu commented Feb 6, 2021

Ok great fixed

Copy link
Contributor

@tmabraham tmabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@hamelsmu hamelsmu merged commit 135163f into master Feb 6, 2021
@tmabraham tmabraham mentioned this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants