fix: nbdev_new encounters 404 error with custom GH_HOST
#1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hamelsmu
reviewed
Sep 8, 2022
hamelsmu
reviewed
Sep 8, 2022
| @@ -60,6 +60,7 @@ | |||
| "outputs": [], | |||
There was a problem hiding this comment.
Line #12. tag = GhApi(gh_host='https://api.github.com').repos.get_latest_release('fastai', 'nbdev-template').tag_name
I am not confident about this change - my main question is are we sure that all other endpoints other than https://api.github.com do not work? For example, GitHub Enterprise?
It could be that the OpenAPI spec that ghapi is built on only works with the public GitHub API or something like that, but just curious if you happen to know any more details or have some thoughts around this
Reply via ReviewNB
You are fancy 💃🏽 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hamelsmu @jph00