Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make anaconda description links consistent with pypi #1214

Merged
merged 1 commit into from Nov 12, 2022
Merged

make anaconda description links consistent with pypi #1214

merged 1 commit into from Nov 12, 2022

Conversation

restlessronin
Copy link
Contributor

The home, dev and doc url's on anaconda were all being set to the "doc_host", which results in broken links on anaconda.

I fixed the urls to match the pypi case. Home and Dev url's point to the github repo, and doc url points to the doc_host + doc_baseurl (github pages in most cases i think)

Here's a screenshot of the anaconda page after the fix. All the urls are now working

Screen Shot 2022-11-08 at 8 02 53 PM

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seeM seeM added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 12, 2022
@seeM seeM changed the title make anaconda links similar to pypi links make anaconda description links consistent with pypi Nov 12, 2022
@seeM seeM merged commit d1aed70 into fastai:master Nov 12, 2022
@restlessronin restlessronin deleted the fix-anaconda-links branch November 12, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants