Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 0 - Pre-planning status #1262

Merged
merged 1 commit into from Jan 31, 2023
Merged

add 0 - Pre-planning status #1262

merged 1 commit into from Jan 31, 2023

Conversation

ddobrinskiy
Copy link
Contributor

the logic here is that setup.py uses indexing on the statuses list

since python is 0-indexed, putting 4 as status in settings.ini actually sets it at 5 - Production/Stable instead of 4 - Beta as one might expect, and so on

the logic here is that setup.py uses indexing on the statuses list

since python is 0-indexed, putting 4 as status in settings.ini actually sets it at '5 - Production/Stable' instead of '4 - Beta' as one might expect, and so on
@hugetim
Copy link
Contributor

hugetim commented Jan 13, 2023

I can confirm this fix is needed. I had to set my settings.ini to 3 to get it to show up as 4 on pypi.

@jph00 jph00 merged commit 483426e into fastai:master Jan 31, 2023
@jph00
Copy link
Member

jph00 commented Jan 31, 2023

Many thanks!

@jph00 jph00 added the enhancement New feature or request label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants