Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support windows #392

Merged
merged 7 commits into from Jan 22, 2021
Merged

support windows #392

merged 7 commits into from Jan 22, 2021

Conversation

mszhanyi
Copy link

@mszhanyi mszhanyi commented Jan 20, 2021

fix #393

  1. 01_sync.ipynb and 03_export2html.ipynb failed in windows
  2. The reasons are
    2.1 Unix path is not applicable on Windows
    2.2 Notebook could not use parallel on Windows

image

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jph00 jph00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the PR! Just one suggestion to try out please.

nbdev/export2html.py Outdated Show resolved Hide resolved
@jph00
Copy link
Member

jph00 commented Jan 21, 2021 via email

@jph00
Copy link
Member

jph00 commented Jan 21, 2021 via email

@mszhanyi
Copy link
Author

@mszhanyi mszhanyi requested a review from jph00 January 22, 2021 17:51
@jph00
Copy link
Member

jph00 commented Jan 22, 2021

Super - thank you :)

@jph00 jph00 merged commit 1db6aa6 into fastai:master Jan 22, 2021
@hamelsmu hamelsmu added the enhancement New feature or request label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

01_sync and 03_export2html failed on Windows
3 participants