Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user option to jupyter_hooks setting #738

Merged
merged 1 commit into from Aug 4, 2022

Conversation

seeM
Copy link
Member

@seeM seeM commented Aug 3, 2022

Note that this isn't yet useful. I'm considering changing get_config to read ~/.nbdev/settings.ini if it exists, then update it with $(pwd)/settings.ini, then jupyter_hooks=user will be useful. @hamelsmu @jph00 what do you think?

@seeM seeM added the enhancement New feature or request label Aug 3, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seeM seeM merged commit 9953eab into fastai:master Aug 4, 2022
@seeM seeM deleted the jupyter-hooks-user branch August 4, 2022 03:58
@jph00
Copy link
Member

jph00 commented Aug 4, 2022

@seeM how about for the location we follow the XDG spec?

$XDG_CONFIG_HOME defines the base directory relative to which user-specific configuration files should be stored. If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.

@jph00
Copy link
Member

jph00 commented Aug 4, 2022

I've just added a new module fastcore.xdg to make this more convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants