Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cell index in nbdev_update #934

Merged
merged 1 commit into from Aug 25, 2022
Merged

Correct cell index in nbdev_update #934

merged 1 commit into from Aug 25, 2022

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Aug 25, 2022

Fixes #775

I was surprised this was the fix, but it was for me. I've tested it a bunch

cc: @jph00 @seeM

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu changed the title Correct cell index in update Correct cell index in nbdev_update Aug 25, 2022
@hamelsmu hamelsmu added the bug Something isn't working label Aug 25, 2022
@jph00 jph00 merged commit 481636b into master Aug 25, 2022
@jph00 jph00 deleted the fix-update branch August 25, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbdev_update creates a new cell, instead of updating the original code
2 participants