Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ensure permissions. Fix invalid default project name if destination is . #188

Merged
merged 6 commits into from
Oct 16, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Oct 16, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #187
Resolves: #185

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added bug Something isn't working enhancement New feature or request labels Oct 16, 2022
@rszamszur rszamszur self-assigned this Oct 16, 2022
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request October 16, 2022 10:43 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #188 (86888d8) into master (21c92d8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          291       310   +19     
=========================================
+ Hits           291       310   +19     
Impacted Files Coverage Δ
fastapi_mvc/cli/new.py 100.00% <100.00%> (ø)
fastapi_mvc/core.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rszamszur rszamszur merged commit 938813a into master Oct 16, 2022
@rszamszur rszamszur deleted the implement_ensure_premissions branch October 16, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid default project name if destination is . Implement ensure_permission method
2 participants