Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement run command for uvicorn development server #35

Merged
merged 12 commits into from
Feb 7, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Feb 6, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #31, resolves: #14

Description of the changes being introduced by the pull request:
TODO:

  • Fix unit tests
  • Add unit test for CLI run command
  • Update documentation

@rszamszur rszamszur added the enhancement New feature or request label Feb 6, 2022
@rszamszur rszamszur added this to the 0.8.0 milestone Feb 6, 2022
@rszamszur rszamszur self-assigned this Feb 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

@rszamszur rszamszur marked this pull request as ready for review February 7, 2022 20:01
@codecov-commenter
Copy link

Codecov Report

Merging #35 (5e1cdfd) into master (fe2ca54) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   99.18%   99.24%   +0.05%     
==========================================
  Files          15       16       +1     
  Lines         369      396      +27     
==========================================
+ Hits          366      393      +27     
  Misses          3        3              
Impacted Files Coverage Δ
fastapi_mvc/cli/cli.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/commands/new.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/commands/run.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8438e3...5e1cdfd. Read the comment docs.

@rszamszur rszamszur merged commit 83b983b into master Feb 7, 2022
@rszamszur rszamszur deleted the add_run_dev_server branch February 7, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart workers when code changes in development mode Implement run command
2 participants