Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #39 #42

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Fix #39 #42

merged 3 commits into from
Feb 8, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Feb 8, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #39

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added the bug Something isn't working label Feb 8, 2022
@rszamszur rszamszur added this to the 0.8.0 milestone Feb 8, 2022
@rszamszur rszamszur self-assigned this Feb 8, 2022
@rszamszur rszamszur changed the title Fix #38 Fix #39 Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #42 (b521277) into master (fe2ca54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   99.18%   99.19%           
=======================================
  Files          15       16    +1     
  Lines         369      371    +2     
=======================================
+ Hits          366      368    +2     
  Misses          3        3           
Impacted Files Coverage Δ
fastapi_mvc/cli/cli.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/commands/new.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/commands/run.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec1b21...b521277. Read the comment docs.

@rszamszur
Copy link
Member Author

Ignore the branch name, I've provided the wrong issue number.

@rszamszur rszamszur merged commit 4d137ff into master Feb 8, 2022
@rszamszur rszamszur deleted the fix_#38 branch February 8, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI fastapi-mvc new --license option value is not passed to cookiecutter
2 participants