Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements #58

Merged
merged 7 commits into from
Apr 4, 2022
Merged

Add improvements #58

merged 7 commits into from
Apr 4, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Apr 4, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #57
Resolves: #59

Description of the changes being introduced by the pull request:

  • Add minor ShellUtils unit test case improvement.
  • Allow overriding poetry version for make install target via env variable: $POETRY_VERSION
  • Add nix shell config for local development environment

@rszamszur rszamszur added the enhancement New feature or request label Apr 4, 2022
@rszamszur rszamszur added this to the 0.10.0 milestone Apr 4, 2022
@rszamszur rszamszur self-assigned this Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #58 (bb2a9a1) into master (467f29b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          34       34           
  Lines         591      591           
=======================================
  Hits          588      588           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321130d...bb2a9a1. Read the comment docs.

@rszamszur rszamszur merged commit acdde1d into master Apr 4, 2022
@rszamszur rszamszur deleted the add_improvements branch April 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants