-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install fail when Python version >= 3.10 #61
Conversation
A bash condition leads to Python 3.10 being "lower" than Python 3.7, thus the installation of fastapi-mvc would fail.
Should I implement #62 in the same PR or should we let this good first issue to anyone that would like to contribute? |
@Merinorus Feel free to implement #62 as well if you'd like. Even though it's an easy issue, I don't think it should wait just because of that (at least in this case). |
Also add Python 3.10 to CI (implements fastapi-mvc#62)
Oops... Github actions thinks it's Python 3.1 instead of 3.10... |
Yep, I also didn't see that coming 😆 |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 34 34
Lines 591 591
=======================================
Hits 588 588
Misses 3 3 Continue to review full report at Codecov.
|
Lol, I also thought it was an easy fix! |
Don't worry about failing CI metrics for 3.10; it seems there is a typo. "$POETRY_HOME"/bin/poetry run flake8 --select=T --tee --exclude fastapi_mvc/template--output-file=todo_occurence.txt --statistics --count fastapi_mvc tests
# VS
"$POETRY_HOME"/bin/poetry run flake8 --select=T --tee --exclude fastapi_mvc/template --output-file=todo_occurence.txt --statistics --count fastapi_mvc tests But I wonder how it didn't fail before for other py versions. |
And even if in fact flake8 version bump will be needed it can be done via the separate issue and PR. If K8s integration will pass, this is good to merge. Thanks again for the contribution! |
A bash condition leads to Python 3.10 being "lower" than Python 3.7, thus the installation of fastapi-mvc would fail.
Checklist:
CHANGELOG.md
file with your changes.Resolves: #60
Description of the changes being introduced by the pull request: The python version bash condition is changed so Python version >=10 should also pass.