Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of generators feature #70

Merged
merged 60 commits into from
Apr 22, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Apr 12, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #69
Resolves: #68
Resolves: #47
Resolves: #71
Resolves: #72
Resolves: #73

Description of the changes being introduced by the pull request:

TODO:

  • Implement base abstract class for all generators to inherit
  • Solve the problem of dynamically creating click sub-commands at runtime - add initial implementation.
  • Implement method for programmatically loading user generated generators from path at runtime
  • Solve the problem of dynamically creating click sub-commands arguments and options at runtime based on chosen generators - add initial implementation
  • Implement controller generator with template
  • Implement generator generator with template
  • Refactor invoker with using deque
  • Refactor fastapi_mvc.commands to be more generic
  • Implement global except hook, refactor current project exceptions
  • Add and modify unit test cases
  • Add docstrings
  • Fix styleguide
  • Add integration tests for builtins generators -> will be done via Add integration tests for fastapi-mvc generators #76
  • Add integration tests for programmatically loading user generators

This will be a looooong merge 🚀

@rszamszur rszamszur added the enhancement New feature or request label Apr 12, 2022
@rszamszur rszamszur added this to the 0.11.0 milestone Apr 12, 2022
@rszamszur rszamszur self-assigned this Apr 12, 2022
@rszamszur rszamszur changed the title Implement logic for generators Initial implementation of generators feature Apr 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2022

@rszamszur rszamszur added the refactor Related to major code refactoring/reorganisation label Apr 16, 2022
@rszamszur
Copy link
Member Author

rszamszur commented Apr 21, 2022

To not make this merge much more extensive, documentation will be added via separate PR

Related issues:
#74
#75

@rszamszur rszamszur marked this pull request as ready for review April 22, 2022 18:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #70 (8b5a987) into master (ffb5cf3) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   99.49%   99.63%   +0.14%     
==========================================
  Files          34       39       +5     
  Lines         591      817     +226     
==========================================
+ Hits          588      814     +226     
  Misses          3        3              
Impacted Files Coverage Δ
fastapi_mvc/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/borg.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/cli.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/generate.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/new.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/run.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/generate.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/invoker.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/run_shell.py 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb5cf3...8b5a987. Read the comment docs.

@rszamszur rszamszur merged commit ca295e8 into master Apr 22, 2022
@rszamszur rszamszur deleted the add_controller_generator branch April 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Related to major code refactoring/reorganisation
Projects
None yet
2 participants