Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run poetry with abspath, fix fastapi-mvc run implementation #86

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Apr 24, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #82
Resolves: #84

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added the bug Something isn't working label Apr 24, 2022
@rszamszur rszamszur added this to the 0.11.0 milestone Apr 24, 2022
@rszamszur rszamszur self-assigned this Apr 24, 2022
@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #86 (f9ae175) into master (ffb5cf3) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   99.49%   99.62%   +0.13%     
==========================================
  Files          34       39       +5     
  Lines         591      808     +217     
==========================================
+ Hits          588      805     +217     
  Misses          3        3              
Impacted Files Coverage Δ
fastapi_mvc/commands/base.py 100.00% <ø> (ø)
fastapi_mvc/generators/project.py 100.00% <ø> (ø)
fastapi_mvc/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/borg.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/cli.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/generate.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/new.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/run.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/generate.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2d453...f9ae175. Read the comment docs.

@rszamszur rszamszur merged commit 9ec7ecf into master Apr 24, 2022
@rszamszur rszamszur deleted the run_poetry_abspath branch April 24, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants